fix(memory): Replace the outdated manual way of creating the ChatMemoryRepository #3532
+68
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryRepository - Update the document information and replace the unavailable creation method of ChatMemoryRepository. - Increase the create function to create Neo4jChatMemoryRepository, this way to manually create the way. Signed-off-by: Caiyu Liu <[email protected]> Signed-off-by: Cyanty <[email protected]>
…ryRepository - Update the document information and replace the unavailable creation method of ChatMemoryRepository. - Increase the create function to create Neo4jChatMemoryRepository, this way to manually create the way. Signed-off-by: Caiyu Liu <[email protected]> Signed-off-by: Cyanty <[email protected]>
…ryRepository - Update the document information and replace the unavailable creation method of ChatMemoryRepository. - Increase the create function to create Neo4jChatMemoryRepository, this way to manually create the way. Signed-off-by: Cyanty <[email protected]>
yuluo-yx
reviewed
Jun 14, 2025
| @@ -56,6 +56,10 @@ public Neo4jChatMemoryRepository(Neo4jChatMemoryRepositoryConfig config) { | |||
| this.config = config; | |||
| } | |||
|
|
|||
| public static Neo4jChatMemoryRepository create(Neo4jChatMemoryRepositoryConfig conf) { | |||
There was a problem hiding this comment.
IMO, wouldn't it be better to use Builder.builder()?
…ryRepository - Update the document information and replace the unavailable creation method of ChatMemoryRepository. - Increase the builder function to create Neo4jChatMemoryRepository, this way to manually create the way. Signed-off-by: Cyanty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, some outdated methods have emerged from using Chat Memory: